starting to write docs, taking decisions on public api

bonobo/ext/console/__init__.py

@@ -1,7 +1,3 @@
-from .helpers import console_run
 from .plugin import ConsoleOutputPlugin
 
-__all__ = [
-    'ConsoleOutputPlugin',
-    'console_run',
-]
+__all__ = ['ConsoleOutputPlugin', ]

bonobo/ext/console/helpers.py

@@ -1,9 +0,0 @@
-from bonobo import Graph, ThreadPoolExecutorStrategy
-from .plugin import ConsoleOutputPlugin
-
-
-def console_run(*chain, output=True, plugins=None):
-    graph = Graph()
-    executor = ThreadPoolExecutorStrategy()
-    graph.add_chain(*chain)
-    return executor.execute(graph, plugins=(plugins or []) + [ConsoleOutputPlugin()] if output else [])

bonobo/ext/jupyter/__init__.py

@@ -1,4 +1,4 @@
-from .helpers import jupyter_run
+from bonobo.util.helpers import jupyter_run
 from .plugin import JupyterOutputPlugin
 
 
@@ -6,7 +6,4 @@ def _jupyter_nbextension_paths():
     return [{'section': 'notebook', 'src': 'static', 'dest': 'bonobo-jupyter', 'require': 'bonobo-jupyter/extension'}]
 
 
-__all__ = [
-    'JupyterOutputPlugin',
-    'jupyter_run',
-]
+__all__ = ['JupyterOutputPlugin', ]

bonobo/ext/jupyter/helpers.py

@@ -1,9 +1 @@
-from bonobo import Graph, ThreadPoolExecutorStrategy
-from .plugin import JupyterOutputPlugin
 
-
-def jupyter_run(*chain, plugins=None):
-    graph = Graph()
-    executor = ThreadPoolExecutorStrategy()
-    graph.add_chain(*chain)
-    return executor.execute(graph, plugins=(plugins or []) + [JupyterOutputPlugin()])

bonobo/ext/opendatasoft.py

@@ -3,11 +3,18 @@ from urllib.parse import urlencode
 import requests  # todo: make this a service so we can substitute it ?
 
 
-def extract_ods(url, dataset, rows=100, **kwargs):
+def from_opendatasoft_api(dataset=None,
+                          endpoint='{scheme}://{netloc}{path}',
+                          scheme='https',
+                          netloc='data.opendatasoft.com',
+                          path='/api/records/1.0/search/',
+                          rows=100,
+                          **kwargs):
+    path = path if path.startswith('/') else '/' + path
     params = (
         ('dataset', dataset),
         ('rows', rows), ) + tuple(sorted(kwargs.items()))
-    base_url = url + '?' + urlencode(params)
+    base_url = endpoint.format(scheme=scheme, netloc=netloc, path=path) + '?' + urlencode(params)
 
     def _extract_ods():
         nonlocal base_url, rows