paulin/bonobo
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Issue #134: use requests.get as a context manager

Browse Source
This commit is contained in:
Michael Penkov
2017-10-28 16:19:05 +02:00
parent eabc79c8ec
commit 3e7898a987
2 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
bonobo/commands/download.py
View File

@ -29,8 +29,7 @@ def execute(path, *args, **kwargs):
raise ValueError('download command currently supports examples only') raise ValueError('download command currently supports examples only')
examples_path = re.sub('^examples/', '', path) examples_path = re.sub('^examples/', '', path)
output_path = bonobo.get_examples_path(examples_path) output_path = bonobo.get_examples_path(examples_path)
response = _open_url(EXAMPLES_BASE_URL + examples_path) with _open_url(EXAMPLES_BASE_URL + examples_path) as response, open(output_path, 'wb') as fout:
with open(output_path, 'wb') as fout:
_write_response(response, fout) _write_response(response, fout)
print('saved to {}'.format(output_path)) print('saved to {}'.format(output_path))

6
tests/test_commands.py
View File

@ -164,6 +164,12 @@ def test_download_works_for_examples(runner):
def iter_content(self, *args, **kwargs): def iter_content(self, *args, **kwargs):
return [expected_bytes] return [expected_bytes]
def __enter__(self):
return self
def __exit__(self, *args, **kwargs):
pass
fout = io.BytesIO() fout = io.BytesIO()
fout.close = lambda: None fout.close = lambda: None