Implements JsonReader (#2)

bonobo/__init__.py

@@ -23,7 +23,7 @@ import os
 import sys
 
 from .core import *
-from .io import *
+from .io import FileReader, FileWriter, JsonReader, JsonWriter
 from .util import *
 
 PY35 = (sys.version_info >= (3, 5))
@@ -36,8 +36,10 @@ with open(os.path.realpath(os.path.join(os.path.dirname(__file__), '../version.t
 
 __all__ = [
     'Bag',
+    'FileReader',
     'FileWriter',
     'Graph',
+    'JsonReader',
     'JsonWriter',
     'NOT_MODIFIED',
     'NaiveStrategy',

bonobo/io/__init__.py

@@ -1,11 +1,11 @@
 """ Readers and writers for common file formats. """
 
-from .file import Handler, FileReader, FileWriter
-from .json import JsonWriter
+from .file import FileReader, FileWriter
+from .json import JsonReader, JsonWriter
 
 __all__ = [
-    'Handler',
     'FileReader',
     'FileWriter',
+    'JsonReader',
     'JsonWriter',
 ]

bonobo/io/file.py

@@ -1,14 +1,14 @@
 from bonobo.util.lifecycle import with_context
 
 __all__ = [
-    'Handler',
+    'FileHandler',
     'FileReader',
     'FileWriter',
 ]
 
 
 @with_context
-class Handler:
+class FileHandler:
     """
     Abstract component factory for file-related components.
 
@@ -44,7 +44,7 @@ class Handler:
         del ctx.file
 
 
-class Reader(Handler):
+class Reader(FileHandler):
     def __call__(self, ctx):
         yield from self.handle(ctx)
 
@@ -52,7 +52,7 @@ class Reader(Handler):
         raise NotImplementedError('Abstract.')
 
 
-class Writer(Handler):
+class Writer(FileHandler):
     def __call__(self, ctx, row):
         return self.handle(ctx, row)
 

bonobo/io/json.py

@@ -1,6 +1,6 @@
 import json
 
-from .file import FileWriter
+from .file import FileWriter, FileReader
 
 __all__ = ['JsonWriter', ]
 
@@ -9,9 +9,14 @@ class JsonHandler:
     eol = ',\n'
 
 
+class JsonReader(JsonHandler, FileReader):
+    def handle(self, ctx):
+        for line in json.load(ctx.file):
+            yield line
+
+
 class JsonWriter(JsonHandler, FileWriter):
     def initialize(self, ctx):
-        print('EOL', self.eol)
         super().initialize(ctx)
         ctx.file.write('[\n')
 

bonobo/util/testing.py

@@ -0,0 +1,9 @@
+from unittest.mock import MagicMock
+
+from bonobo.core.contexts import ComponentExecutionContext
+
+
+class CapturingComponentExecutionContext(ComponentExecutionContext):
+    def __init__(self, component, parent):
+        super().__init__(component, parent)
+        self.send = MagicMock()