From a687a38adf77c4ebbf4562e090a6344916554f03 Mon Sep 17 00:00:00 2001
From: Boris Morel <2323800+borismo@users.noreply.github.com>
Date: Sat, 27 Oct 2018 11:44:57 +0200
Subject: [PATCH 1/4] Add not for Windows users
---
docs/tutorial/1-init.rst | 2 ++
1 file changed, 2 insertions(+)
diff --git a/docs/tutorial/1-init.rst b/docs/tutorial/1-init.rst
index 1668417..eec16a7 100644
--- a/docs/tutorial/1-init.rst
+++ b/docs/tutorial/1-init.rst
@@ -59,6 +59,8 @@ To inspect the graph of your first transformation:
You must `install the graphviz software first `_. It is _not_ the python's graphviz
package, you must install it using your system's package manager (apt, brew, ...).
+
+ For Windows users: you might need to add an entry to the Path environment variable for the `dot` command to be recognized
.. code-block:: shell-session
From 633c30390f3eb6f910b2ef943029deda97137abb Mon Sep 17 00:00:00 2001
From: Romain Dorgueil
Date: Sat, 27 Oct 2018 11:55:05 +0200
Subject: [PATCH 2/4] Update jupyter.rst
---
docs/extension/jupyter.rst | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/docs/extension/jupyter.rst b/docs/extension/jupyter.rst
index 75328a3..b702793 100644
--- a/docs/extension/jupyter.rst
+++ b/docs/extension/jupyter.rst
@@ -16,7 +16,7 @@ Install `bonobo` with the **jupyter** extra::
Install the jupyter extension::
jupyter nbextension enable --py --sys-prefix widgetsnbextension
- jupyter nbextension enable --py --sys-prefix bonobo.ext.jupyter
+ jupyter nbextension enable --py --sys-prefix bonobo.contrib.jupyter
Development
:::::::::::
@@ -25,8 +25,8 @@ You should favor yarn over npm to install node packages. If you prefer to use np
To install the widget for development, make sure you're using an editable install of bonobo (see install document)::
- jupyter nbextension install --py --symlink --sys-prefix bonobo.ext.jupyter
- jupyter nbextension enable --py --sys-prefix bonobo.ext.jupyter
+ jupyter nbextension install --py --symlink --sys-prefix bonobo.contrib.jupyter
+ jupyter nbextension enable --py --sys-prefix bonobo.contrib.jupyter
If you want to change the javascript, you should run webpack in watch mode in some terminal::
From 08e07cd7d96b1755761cc5c0ee696d352d39436d Mon Sep 17 00:00:00 2001
From: Romain Dorgueil
Date: Sat, 27 Oct 2018 11:58:54 +0200
Subject: [PATCH 3/4] Update 1-init.rst
---
docs/tutorial/1-init.rst | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/docs/tutorial/1-init.rst b/docs/tutorial/1-init.rst
index 1668417..2dce510 100644
--- a/docs/tutorial/1-init.rst
+++ b/docs/tutorial/1-init.rst
@@ -203,12 +203,17 @@ Main Block
get_graph(**options),
services=get_services(**options)
)
-
+
Here, the real thing happens.
Without diving into too much details for now, using the :func:`bonobo.parse_args` context manager will allow our job to
be configurable, later, and although we don't really need it right now, it does not harm neither.
+.. note::
+
+ This is intended to run in a console terminal. If you're working in a jupyter notebook, you need to adapt the thing to
+ avoid trying to parse arguments, or you'll get into trouble.
+
Reading the output
::::::::::::::::::
From 7c46921985e11b542d934aaf832df49d8a728a9c Mon Sep 17 00:00:00 2001
From: Jostein Leira
Date: Wed, 28 Nov 2018 10:58:56 +0100
Subject: [PATCH 4/4] Remove not needed dict from example.
---
docs/guide/purity.rst | 1 -
1 file changed, 1 deletion(-)
diff --git a/docs/guide/purity.rst b/docs/guide/purity.rst
index df932a4..edfd930 100644
--- a/docs/guide/purity.rst
+++ b/docs/guide/purity.rst
@@ -135,7 +135,6 @@ Now let's see how to do it correctly:
}
def new_dict_and_yield():
- d = {}
for i in range(100):
# Different dict each time.
yield {