API is cleaner this way, easier to understand the purpose of methods (#2).

This commit is contained in:
Romain Dorgueil
2016-12-28 11:40:03 +01:00
parent 67e25b92e1
commit cebb8df173
3 changed files with 17 additions and 19 deletions

View File

@ -8,17 +8,15 @@ from bonobo.util.tokens import BEGIN, END
def test_write_json_to_file(tmpdir):
file = tmpdir.join('output.json')
json_writer = JsonWriter(str(file))
context = ComponentExecutionContext(json_writer, None)
writer = JsonWriter(str(file))
context = ComponentExecutionContext(writer, None)
context.initialize()
context.recv(BEGIN, Bag({'foo': 'bar'}), END)
context.step()
context.finalize()
assert file.read() == '''[
{"foo": "bar"}
]'''
assert file.read() == '[\n{"foo": "bar"}\n]'
with pytest.raises(AttributeError):
getattr(context, 'file')
@ -29,11 +27,11 @@ def test_write_json_to_file(tmpdir):
def test_write_json_without_initializer_should_not_work(tmpdir):
file = tmpdir.join('output.json')
json_writer = JsonWriter(str(file))
writer = JsonWriter(str(file))
context = ComponentExecutionContext(json_writer, None)
context = ComponentExecutionContext(writer, None)
with pytest.raises(AttributeError):
json_writer(context, {'foo': 'bar'})
writer(context, {'foo': 'bar'})
def test_read_json_from_file(tmpdir):