From dee719f0708c5e29e68cee7e0ccf61b484341e17 Mon Sep 17 00:00:00 2001
From: Romain Dorgueil <romain@dorgueil.net>
Date: Sat, 1 Jun 2019 09:32:22 +0200
Subject: [PATCH] #302: adds unit test and doc tidying.

---
 bonobo/nodes/io/csv.py     | 19 +++----------------
 tests/nodes/io/test_csv.py | 16 ++++++++++++++++
 2 files changed, 19 insertions(+), 16 deletions(-)

diff --git a/bonobo/nodes/io/csv.py b/bonobo/nodes/io/csv.py
index 49d8a3d..6fd0c5e 100644
--- a/bonobo/nodes/io/csv.py
+++ b/bonobo/nodes/io/csv.py
@@ -54,16 +54,10 @@ class CsvHandler(FileHandler):
 @use_context
 class CsvReader(FileReader, CsvHandler):
     """
-    Reads a CSV and yield the values as dicts.
+    Reads a CSV and yield the values.
     """
 
-    skip = Option(
-        int,
-        default=0,
-        __doc__="""
-        If set and greater than zero, the reader will skip this amount of lines.
-    """,
-    )
+    skip = Option(int, default=0, __doc__="If set and greater than zero, the reader will skip this amount of lines.")
 
     @Method(
         positional=False,
@@ -96,14 +90,7 @@ class CsvReader(FileReader, CsvHandler):
 
 @use_context
 class CsvWriter(FileWriter, CsvHandler):
-
-    skip_header = Option(
-        bool,
-        default=False,
-        __doc__="""
-        If true, the writer will not produce a file header
-    """,
-    )
+    skip_header = Option(bool, default=False, __doc__="If true, the writer will not produce a file header.")
 
     @Method(
         __doc__="""
diff --git a/tests/nodes/io/test_csv.py b/tests/nodes/io/test_csv.py
index 131c88e..6fda2e9 100644
--- a/tests/nodes/io/test_csv.py
+++ b/tests/nodes/io/test_csv.py
@@ -89,6 +89,22 @@ class CsvWriterTest(Csv, WriterTest, TestCase):
 
         assert self.readlines() == ("foo,bar", "a,b", "c,d")
 
+    @incontext(skip_header=False)
+    def test_fields_with_headers(self, context):
+        context.set_input_fields(["foo", "bar"])
+        context.write_sync(("a", "b"), ("c", "d"))
+        context.stop()
+
+        assert self.readlines() == ("foo,bar", "a,b", "c,d")
+
+    @incontext(skip_header=True)
+    def test_fields_without_headers(self, context):
+        context.set_input_fields(["foo", "bar"])
+        context.write_sync(("a", "b"), ("c", "d"))
+        context.stop()
+
+        assert self.readlines() == ("a,b", "c,d")
+
     @incontext()
     def test_fields_from_type(self, context):
         context.set_input_type(namedtuple("Point", "x y"))