Fixes unused return variable, restore stdout/stderr even if there is an error.

2019-05-16 10:19:47 +01:00
parent 72a855729c
commit 361b0b7ecc
1 changed files with 4 additions and 3 deletions
--- a/bonobo/contrib/django/commands.py
+++ b/bonobo/contrib/django/commands.py
@ -77,6 +77,7 @@ class ETLCommand(BaseCommand):
        self.stderr = OutputWrapper(ConsoleOutputPlugin._stderr, ending=CLEAR_EOL + "\n")
        self.stderr.style_func = lambda x: Fore.LIGHTRED_EX + Back.RED + "!" + Style.RESET_ALL + " " + x

-        results = self.run(*args, **options)
-
-        self.stdout, self.stderr = _stdout_backup, _stderr_backup
+        try:
+            return self.run(*args, **options)
+        finally:
+            self.stdout, self.stderr = _stdout_backup, _stderr_backup