Issue #134: add a bonobo download url command

This enables users on different platforms to download the examples in
the tutorial using the same command.
This commit is contained in:
Michael Penkov
2017-10-28 14:08:53 +02:00
parent bf5f870304
commit 9e86abca60
4 changed files with 80 additions and 1 deletions

View File

@ -0,0 +1,43 @@
import io
import re
import urllib.request
import bonobo
EXAMPLES_BASE_URL = 'https://raw.githubusercontent.com/python-bonobo/bonobo/master/bonobo/examples/'
"""The URL to our git repository, in raw mode."""
def _save_stream(fin, fout):
"""Read the input stream and write it to the output stream block-by-block."""
while True:
data = fin.read(io.DEFAULT_BUFFER_SIZE)
if data:
fout.write(data)
else:
break
def _open_url(url):
"""Open a HTTP connection to the URL and return a file-like object."""
response = urllib.request.urlopen(url)
if response.getcode() != 200:
raise IOError('unable to download {}, HTTP {}'.format(url, response.getcode()))
return response
def execute(path, *args, **kwargs):
path = path.lstrip('/')
if not path.startswith('examples'):
raise ValueError('download command currently supports examples only')
examples_path = re.sub('^examples/', '', path)
output_path = bonobo.get_examples_path(examples_path)
fin = _open_url(EXAMPLES_BASE_URL + examples_path)
with open(output_path, 'wb') as fout:
_save_stream(fin, fout)
print('saved to {}'.format(output_path))
def register(parser):
parser.add_argument('path', help='The relative path of the thing to download.')
return execute

View File

@ -1,6 +1,17 @@
Changelog
=========
Unreleased
::::::::::
New features
------------
Command line
............
* `bonobo download /examples/datasets/coffeeshops.txt` now downloads the coffeeshops example
v.0.5.0 - 5 october 2017
::::::::::::::::::::::::

View File

@ -69,7 +69,8 @@ setup(
'bonobo.commands': [
'convert = bonobo.commands.convert:register', 'init = bonobo.commands.init:register',
'inspect = bonobo.commands.inspect:register', 'run = bonobo.commands.run:register',
'version = bonobo.commands.version:register'
'version = bonobo.commands.version:register',
'download = bonobo.commands.download:register',
],
'console_scripts': ['bonobo = bonobo.commands:entrypoint']
},

View File

@ -13,6 +13,7 @@ from cookiecutter.exceptions import OutputDirExistsException
from bonobo import __main__, __version__, get_examples_path
from bonobo.commands import entrypoint
from bonobo.commands.run import DEFAULT_GRAPH_FILENAMES
from bonobo.commands.download import EXAMPLES_BASE_URL
def runner(f):
@ -152,6 +153,29 @@ def test_version(runner):
assert __version__ in out
@all_runners
def test_download_works_for_examples(runner):
fout = io.BytesIO()
fout.close = lambda: None
expected_bytes = b'hello world'
with patch('bonobo.commands.download._open_url') as mock_open_url, \
patch('bonobo.commands.download.open') as mock_open:
mock_open_url.return_value = io.BytesIO(expected_bytes)
mock_open.return_value = fout
runner('download', 'examples/datasets/coffeeshops.txt')
expected_url = EXAMPLES_BASE_URL + 'datasets/coffeeshops.txt'
mock_open_url.assert_called_once_with(expected_url)
assert fout.getvalue() == expected_bytes
@all_runners
def test_download_fails_non_example(runner):
with pytest.raises(ValueError):
runner('download', '/something/entirely/different.txt')
@all_runners
class TestDefaultEnvFile(object):
def test_run_file_with_default_env_file(self, runner):