comparison to None|True|False should be 'if cond is None:'

tests/config/test_configurables.py

@@ -67,7 +67,7 @@ def test_defaults():
 
     assert o.required_str == 'hello'
     assert o.default_str == 'foo'
-    assert o.integer == None
+    assert o.integer is None
 
 
 def test_str_type_factory():
@@ -78,7 +78,7 @@ def test_str_type_factory():
 
     assert o.required_str == '42'
     assert o.default_str == 'foo'
-    assert o.integer == None
+    assert o.integer is None
 
 
 def test_int_type_factory():
@@ -100,8 +100,8 @@ def test_bool_type_factory():
 
     assert o.required_str == 'yes'
     assert o.default_str == 'foo'
-    assert o.integer == None
-    assert o.also_required == True
+    assert o.integer is None
+    assert o.also_required is True
 
 
 def test_option_resolution_order():
@@ -112,7 +112,7 @@ def test_option_resolution_order():
 
     assert o.required_str == 'kaboom'
     assert o.default_str == 'foo'
-    assert o.integer == None
+    assert o.integer is None
 
 
 def test_option_positional():

tests/test_settings.py

@@ -42,9 +42,9 @@ def test_setting():
 def test_default_settings():
     settings.clear_all()
 
-    assert settings.DEBUG.get() == False
-    assert settings.PROFILE.get() == False
-    assert settings.QUIET.get() == False
+    assert settings.DEBUG.get() is False
+    assert settings.PROFILE.get() is False
+    assert settings.QUIET.get() is False
     assert settings.LOGGING_LEVEL.get() == logging._checkLevel('INFO')
 
     with patch.dict(environ, {'DEBUG': 't'}):

tests/util/test_iterators.py

@@ -18,5 +18,5 @@ def test_force_iterator_with_generator():
         yield 'ccc'
 
     iterator = force_iterator(generator())
-    assert type(iterator) == types.GeneratorType
+    assert isinstance(iterator, types.GeneratorType)
     assert list(iterator) == ['aaa', 'bbb', 'ccc']